Tim te Beek
Tim te Beek
That's good context thanks; guess we hadn't ever seen that type of use before, and we'll likely need to accommodate that in the parser. As it's the first time seeing...
@knutwannheden any insights here given your work on - https://github.com/openrewrite/rewrite/pull/5234 ? https://github.com/openrewrite/rewrite/blob/d7bb97c1369a8a3bbfdf7de8ad0ec841044c3f1b/rewrite-core/src/main/java/org/openrewrite/internal/RecipeIntrospectionUtils.java#L123-L127
Thanks for the runnable example! Odd how we're repeating those last two characters. 🤔 Any chance you've briefly explored a fix already? Just so we know what to expect. No...
[Gradle 9](https://github.com/gradle/gradle/releases/tag/v9.0.0-RC1) should be interesting, as that now requires Kotlin 2.1. All the more appreciative of your efforts here!
Linking the relevant [thread in the Kotlin lang Slack](https://slack-chats.kotlinlang.org/t/28493795/what-is-the-recommended-way-to-migrate-firsessionfactoryhelp#997dab2b-2e41-4549-9721-ae0192a3f337) here as well. Let us know if you could use more help!
Thanks for your interest @e5l ; there's also this parallel alternative approach, where we're exploring a separate Kotlin 2 parser which more closely matches the model of the underlying compiler:...
I've found this migration guide showing a number of dependency, package and class changes, that should be fairly easy to add as declarative recipes: https://jetty.org/docs/jetty/12/programming-guide/migration/11-to-12.html ```yaml type: specs.openrewrite.org/v1beta/recipe name: org.openrewrite.java.JettyPackageChanges...
hi @rahul3509 ; thanks for the report! It looks like we did specify `//` for comments as well: https://github.com/openrewrite/rewrite/blob/6602fe7ddc634787070bd58c1aa96081fb6c6c7c/rewrite-hcl/src/main/antlr/HCLLexer.g4#L53-L54 The parser seems to stumble over adding those trailing comments, which...
Thanks for diving in! Looks like we're failing to pick up on trailing comments. I'm traveling right now so I can't look closely, but do keep me posted about your...
Great to follow your progress here @rahul3509 Sounds like you're on the right track. Look forward to what you'll come up with.