Tim te Beek

Results 1243 comments of Tim te Beek

> **Summary** > > I successfully fixed the `dontRemoveNecessaryDowncast` test in `RemoveRedundantTypeCastTest`. The issue was that the recipe was incorrectly removing a type cast in a generic method call chain:...

Thanks @blipper ; indeed seems reasonable not to make any changes to variables annotated as non-nullable. Another case where having nullability included in the type system would help: - https://github.com/openrewrite/rewrite/issues/3221

Agreed that it would be nice to pull this over to the docs; perhaps starting with the video, and the write up we did on that video: https://github.com/moderneinc/moderne-docs/blob/main/docs/user-documentation/community-office-hours.md#enlightening-lsts-with-traits-july-17th-2024

Thanks for pointing this out! Indeed it's hard to keep the plugin documentation updated when it's not automatically generated; for the Maven plugin we have an alternative in the form...

hi! The recipe does indeed require that you're running at least Java 17, as determined by a marker that we upgrade as part of a Java version bump. Linking the...

Thanks for the reproducer steps.. Can't yet look in detail as I'm traveling/PTO for the next week or so, followed by conference. Any help appreciated!

Thanks for the runnable report! I think this might be a slightly different case as there's no generics involved, right? Did you already explore a potential fix by running the...

If you're up for it a draft PR that adds that test would be most helpful; no expectation that you'll work on a fix, but it makes it so we...

- Fixed in https://github.com/openrewrite/rewrite-static-analysis/pull/495