Tim Abbott

Results 1353 comments of Tim Abbott

And for the first commit: ``` diff diff --git a/web/src/echo.ts b/web/src/echo.ts index 1f8e3689ef..2841862575 100644 --- a/web/src/echo.ts +++ b/web/src/echo.ts @@ -237,10 +237,8 @@ export function build_display_recipient(message: LocalMessage): DisplayRecipient return display_recipient; }...

With those changes, I think this is good to merge. Thanks for making this happen @roanster007! It's the kind of sensitive code where it's important to have well-written comment documentation,...

Merged, thanks @sujalshah-bit and reviewers!

Merged, but note the two above things that I noticed (not new bugs in this code) that likely deserve attention before we can start using this feature more broadly. Thanks...

Hmm, yeah, that could be nice. Do you have a suggestion of how you'd want the interface to work for that?

Merged, thanks @Jai0401! It looks like there's still a cluster of template files to rename visible via `ls web/templates/settings/*display_settings*`; one will need to be careful to update how they're included...

Yeah it'd be great if we can merge some of the refactoring in preparatory commits.

I did a review of this; I think it's potentially realistic for this to be included in 11.0 with the approach suggested above, which would greatly shrink this PR and...

It looks like this might be a bug with the postgres repository upstream; https://apt.postgresql.org/pub/repos/apt/pool/ is missing a `16` directory.

We're definitely going to test-deploy on chat.zulip.org; I'm not sure it's going to be a mergeable checkpoint. Two things need testing: - The increased space between the icons and the...