zulip icon indicating copy to clipboard operation
zulip copied to clipboard

settings: Rename user_display_settings to user_preferences.

Open Jai0401 opened this issue 1 year ago • 2 comments

Finished renaming user_display_settings to user_preferences.

Fixes part of zulip#26874.

this pull request:

Renames user_display_settings to user_preferences.

Changed Files: web/src/server_events_dispatch.js web/src/settings_config.ts web/templates/settings/display_settings_general.hbs web/templates/settings/display_settings_information.hbs

Self-review checklist
  • [x] Self-reviewed the changes for clarity and maintainability (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • [ ] Explains differences from previous plans (e.g., issue description).
  • [ ] Highlights technical choices and bugs encountered.
  • [ ] Calls out remaining decisions and concerns.
  • [ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • [x] Each commit is a coherent idea.
  • [x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • [ ] Visual appearance of the changes.
  • [ ] Responsiveness and internationalization.
  • [ ] Strings and tooltips.
  • [ ] End-to-end functionality of buttons, interactions and flows.
  • [x] Corner cases, error conditions, and easily imagined bugs.

Jai0401 avatar Aug 23 '24 05:08 Jai0401

@sahil839 are you up for reviewing this one?

alya avatar Aug 27 '24 20:08 alya

Looks good to me. @timabbott ready for your review.

sahil839 avatar Aug 28 '24 08:08 sahil839

Merged, thanks @Jai0401!

It looks like there's still a cluster of template files to rename visible via ls web/templates/settings/*display_settings*; one will need to be careful to update how they're included via handlebars partials for that.

timabbott avatar Aug 28 '24 18:08 timabbott