Tim Abbott
Tim Abbott
I've extracted 10 commits to #30584, since the first 11 looked good aside from my being unsure about https://github.com/zulip/zulip/pull/30477#discussion_r1653761464.
I did a straight rebase of this, dropping the commits already merged via #30584.
I think everything but the last 3 commits on this is merged through the PRs we split out from here. I don't think it'd be a bad idea to make...
OK finished my read, all my comments are above.
Rebased to re-insert the previous version that preserved the colorized string diff feature, and to add node testing for `rendered_markdown.ts`. @roanster007 FYI, as the tests that I did here verify...
I think this is the crux of the issue: > Other applications: Other applications also seem unable to display notifications, likely for the same reasons. https://github.com/deltachat/deltachat-desktop/issues/2263 might be somewhat helpful...
Closing as it appears to be an issue with Windows configuration, not Zulip.
I ended up rewriting https://github.com/zulip/zulip/pull/31167#discussion_r1699112981 with a proposal that I think presents a cleaner way to fix this that should also simplify migrating `echo.js` to TypeScript; @LaPulgaaa @afeefuddin FYI.
I merged the first commit as e104fed6ef36e2afde85735f96942ee472f700bb, since that looked good and is the main part that might merge conflict with other work.
I redid the comments and variables in the second commit message, including adding a new TODO comment that I think we might need to resolve before we can make much...