Tim Abbott

Looks great, merged, thanks @mreza-kiani!

This might be a good next one of your PRs to pick up and try to finish, though definitely much lower priority than the remaining topic permalinks PR.

Closing in favor of https://github.com/zulip/zulip/pull/36352, which continues this effort.

@userAdityaa how have you tested this and convinced yourself that it's correct? Can you talk about how you chose what values to pass? We need that kind of detail before...

OK, and how have you tested this?

Can you confirm the testing that you did would behave differently without this change?

I think this PR actually does nothing useful, as the issue was in error. Closing.

Closing as #838 was merged for the original issue. Thanks for the effort @jbhavesh!

I think I've flagged all the implementation concerns I have above. I expect once the above feedback is resolved, I'll do a final round of manual testing and then hopefully...

I made the changes suggested above and am merging this; we'll probably want to do those fixups over the next week, but they seem small and it'll be easier to...