Tim Abbott

Results 1442 comments of Tim Abbott

Can you present before/after screenshots? Also, I'm not sure which component is the `settings_description` part.

OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying?

As a random sidenote, I generally recommend committing developer documentation like a "release checklist" in `docs/` folder rather than using the GitHub wikis; that way content in it shows up...

While Zulip doesn't have requirements for the redis image, or does need a specific postgreSQL image in order for full-text search to work well. So I am not sure it's...

It isn't; we also see it when minifying our static assets for production. https://github.com/zulip/zulip/pull/545#issuecomment-203739800 has some statistics; the `build-release-tarball` job is building the static assets with `DEBUG=False`.

This issue seems to have gone away for us when we instead upgraded to Pipeline 1.6.8.

The only thing I see in the 1.6.8 release that could have been related to this is: https://github.com/jazzband/django-pipeline/commit/930b12c9307e69cab05ec360efc2714fe008fc21 Is it possible that was a significant performance improvement? If so, I...

Well, the negative part of https://github.com/zulip/zulip/pull/1176/files shows what our configuration was like before we upgraded to 1.6.8 yesterday. Basically we had just this one finder configured: https://github.com/zulip/zulip/blob/1e2d38e790ae61032c981f93e6f0907921c03c4e/zerver/finders.py (This was the...

Looks great, merged, thanks @prakhar1144; but see a comment above for follow-up refactoring to use `zod` to avoid type assertions.

What's the story with the linter errors on this?