zulip-terminal
zulip-terminal copied to clipboard
zulip
run: Add UploadCommand class to automate release process.
Moved this code form https://github.com/zulip/zulint/blob/master/setup.py.
I will just leave this pull request open for now and test merge it when making the next release.
I have made most of the suggested changes. I will document release process in https://github.com/zulip/zulip-terminal/wiki/Making-a-new-release-%F0%9F%8E%89. I don't think we need to add twine and wheel as release deps in setup, I will include it in the docs since they are quite common known deps. I am not sure if pathlib really make an impact here. Yeah, we can move the code to zulint or other places. Thanks @neiljp for great recommendations!
As a random sidenote, I generally recommend committing developer documentation like a "release checklist" in docs/ folder rather than using the GitHub wikis; that way content in it shows up in git grep and is more likely to be updated as changes happen.
@amanagr After discussion over the Summer, I'm wondering if this would be simpler to have as a separate script so that we don't have to include it in setup.py? For example, the python-zulip-api repo has a release-packages script - which admittedly is perhaps more complex than we need.
or leave it? I now think that we should manually verify each step of the release process. While this method is great, I think I will fear using it 😨 !
Heads up @amanagr, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.
