django-pipeline
django-pipeline copied to clipboard
jazzband
Performance issue
Hi, for some reason the performance takes a hit when we upgrade to a newer version of Pipeline. We are currently stuck on version 1.2.2 because of this issue. We have tried with Pipeline 1.6.7 and there is a pull request with some discussion about the issue. Thanks.
Is this during development only? If so, https://github.com/jazzband/django-pipeline/issues/572 might be your issue.
It isn't; we also see it when minifying our static assets for production. https://github.com/zulip/zulip/pull/545#issuecomment-203739800 has some statistics; the build-release-tarball job is building the static assets with DEBUG=False.
This issue seems to have gone away for us when we instead upgraded to Pipeline 1.6.8.
The only thing I see in the 1.6.8 release that could have been related to this is: https://github.com/jazzband/django-pipeline/commit/930b12c9307e69cab05ec360efc2714fe008fc21 Is it possible that was a significant performance improvement? If so, I think that was our issue.
Can you share what your finder configuration looks like? It's definitely possible that it could have a big performance impact.
Well, the negative part of https://github.com/zulip/zulip/pull/1176/files shows what our configuration was like before we upgraded to 1.6.8 yesterday. Basically we had just this one finder configured: https://github.com/zulip/zulip/blob/1e2d38e790ae61032c981f93e6f0907921c03c4e/zerver/finders.py
(This was the original PR that didn't change the finders: https://github.com/zulip/zulip/pull/545/files, and we didn't merge because of this perf issue).