zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Settings: improved visibility of text and buttons

Open Aitchessbee opened this issue 10 months ago • 5 comments

What's this PR do? Improves text and button visibility in settings page as reported in #1357

Screenshots? Old: image

New: image

You have tested this PR on:

  • [ ] Windows
  • [x] Linux/Ubuntu
  • [ ] macOS

Aitchessbee avatar Apr 23 '24 10:04 Aitchessbee

Can you present before/after screenshots? Also, I'm not sure which component is the settings_description part.

timabbott avatar Apr 24 '24 01:04 timabbott

Update the description with old and new images... settings_description is a class given to the text in each row. It was already present in the code but wasn't used in css.

Aitchessbee avatar Apr 24 '24 09:04 Aitchessbee

OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying?

timabbott avatar Apr 25 '24 00:04 timabbott

Maybe, but overall this is a definite improvement.

alya avatar Apr 30 '24 22:04 alya

OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying?

I think the tab headings should also be in dark colour as it will be a good user experience

Axshatt avatar Jul 09 '24 08:07 Axshatt