Tim Abbott
Tim Abbott
@orientor it'd be great if you can do the first review on this.
Yeah, that regex change sounds like a good solution to me.
@orientor feel free to submit that regex change as a separate PR (or @clarammdantas feel free to add it to the start of your branch). We should never allow linters...
@clarammdantas would you be up for rebasing this? If we don't hear from you in the next couple days, I'll assume someone else should pick it up. @orientor @MSurfer20 this...
Cool. Make sure you read the chat.zulip.org thread on the black migration since it provides an easy way to rebase past when we reformatted the codebase. -Tim Abbott (mobile) On...
Awesome!
@MSurfer20 can you rebase this? I think aside from that and my small question above, I should be able to merge this with just a pass on the descriptions.
Closing, as https://github.com/zulip/zulip/pull/30028 is now merged. @Vector73 it's really helpful to cross-link this sort of thing, so we remember to close the old one once something is finished.
Can you clean up this PR? Check out the [Zulip commit guidelines](https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html) for more details, but also please take the time to read our contributing guidelines and advice for creating...
Thoughts on https://github.com/zulip/zulip-desktop/pull/1059#issuecomment-812942418? Is the strategy for this PR that you're just doing a hard-reload of the app to avoid having to solve that problem?