Thomas Eizinger
Thomas Eizinger
Thanks! I'd like to wait for https://github.com/libp2p/rust-libp2p/pull/2922 to merge and then update this!
> I find this more intuitive looking at `ConnectionHandler` only. Though in the greater picture, including `NetworkBehaviour`, it is inconsistent with `NetworkBehaviour::OutEvent`. We can name that one `ToSwarm`? :)
> When first working with `NetworkBehaviour` and `Handler` as a user I struggled quite a bit with understanding how behaviour and handler are related and exchange messages. Same! Especially the...
> > Related to this: What do you think about renaming `NetworkBehaviour::inject_event` -> `::inject_handler_msg` > > With #2867 `NetworkBehaviour::inject_event` would move to `NetworkBehaviour::on_event` via `InEvent::ConnectionHandler`. (Where `InEvent` would be renamed...
Sounds reasonable to me. +1
I think we should also straight-up bump the version in the manifest file and use this new implementation in `libp2p-core`.
It seems we have a CI failure from `cargo deny` because it can't interpret some license properly :/
> I added libp2p-onion to the default features. However this might be a bad idea, since arti has a lot of dependencies and therefore increases the build time of libp2p...
> > It seems we have a CI failure from `cargo deny` because it can't interpret some license properly :/ > > It seems like the license of [bounded-vec-deque](https://crates.io/crates/bounded-vec-deque) and...
> Is there anything left to do for me? Yes, sorry for the delay! - Please fix the merge conflicts - Please adopt our new `feature` handling (no more default...