Thomas Eizinger

Results 1887 comments of Thomas Eizinger

> I like the idea. Though instead of using the `Arc::weak_count` to enforce a limit, I suggest using it to build a Prometheus metric. I would imagine a `Connection` emits...

Sort of. I wouldn't know how to enforce a limit via `Arc::weak_count`? What I am proposing in this issue is to use expose functions on `StreamMuxerBox`: ```rust impl StreamMuxerBox {...

Draft implementation here: https://github.com/libp2p/rust-libp2p/pull/2878 I noticed that we are unnecessarily exposing the `SubstreamBox::new` API publicly which is currently used in a test in `libp2p-swarm`. That test changes with https://github.com/libp2p/rust-libp2p/pull/2861 though...

How is (2) going to work in terms of composing behaviours? One `NetworkBehaviour` declining a connection means it will be denied? i.e. Need full agreement across all `NetworkBehaviour`s?

Going to start on this once https://github.com/libp2p/rust-libp2p/pull/3011 is merged to avoid the churn.

`NetworkBehaviour` already has quite a few callbacks, although we are getting rid of some of them in #3011. Thus, I am a bit hesitant to continue in the direction of...

Hmm, this is in accordance with the spec: https://github.com/libp2p/specs/blob/master/discovery/mdns.md#definitions. After searching the `go-libp2p` repository, I can't find any mention of that specified service name actually so it seems the go...

> In this example from go, seems it use a user input service_name for mdns [libp2p/go-libp2p@`eff72c4`/examples/chat-with-mdns/main.go#L116](https://github.com/libp2p/go-libp2p/blob/eff72c4afafc766a24dd306145ebd4721fe852df/examples/chat-with-mdns/main.go#L116) Correct :) My point still stands, this is not in accordance with the spec....

I don't know much about your usecase but here are some general thoughts: I don't think it is a good idea to only partition a network using different mDNS service...

> Our use case is having several libp2p vpn independent instances talking on the same local network, we don't want those independent vpns to be able to see each other....