rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard
verified publisher icon libp2p

multistream-select: Remove parallel dialing optimization

Open dignifiedquire opened this issue 3 years ago • 2 comments

This is to avoid the usage of the now optional ls command, and stay compatible with go-multistream.

Closes #2925

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

dignifiedquire avatar Sep 23 '22 06:09 dignifiedquire

I think we should also straight-up bump the version in the manifest file and use this new implementation in libp2p-core.

thomaseizinger avatar Sep 23 '22 07:09 thomaseizinger

I think we should also straight-up bump the version in the manifest file and use this new implementation in libp2p-core.

done

dignifiedquire avatar Sep 23 '22 09:09 dignifiedquire

@mxinden anyhing blocking from merging this PR? would be great to have this in

dignifiedquire avatar Sep 27 '22 14:09 dignifiedquire

Not sure why the interoperability tests are failing. I assume due to:

Sep 28 11:02:14.311833	INFO	1.1452s       FAIL << go-latest-v0.22[000] (2e992c) >> failed to dial 12D3KooWBK4ZGwm1kKpPucpiD57hGjvzuDvU4D6eyoLj5EQnNdcm:
  * [/ip4/16.0.0.4/tcp/1234] failed to negotiate security protocol: protocol not supported

I will look further into this.

mxinden avatar Sep 28 '22 11:09 mxinden