Thomas Eizinger
Thomas Eizinger
> I implemented all changes requested. I hope you are pleased with my resolution of the issues with `cargo deny`. Yep, looks all good! I just pushed a few commits...
Can you fix the clippy error please? See https://github.com/libp2p/rust-libp2p/pull/2859 for reference.
> Why did the CI fail? Some download issue during setup of the jobs. I re-triggered them!
> > I will reach out to our legal team as well, just in case. I don't think we need to block on this. > > No objections from our...
Interesting, I wasn't aware that `libp2p-gossipsub` has its own metrics built-in. I think all other protocols collect their metrics by inspecting events emitted from the behaviour. I guess for `libp2p-gossipsub`,...
> metrics were added some good time ago to analyze mesh health and scoring behaviour. Back then we discussed using events as the rest of the protocols but the amount...
I've opened an issue about feature-gating the metrics support: https://github.com/libp2p/rust-libp2p/issues/2923
> > I still don't understand why we need this PR > > Because the default Registry that prometheus exposes has a generic that uses the default text encoder. There...
> > It doesn't compile because the `Encode` derive macro seems to be broken, > > That was my fault when I added the protobuf encoding to `prometheus-client`. Now that...
> I have copied the hack as is on my fork of `prometheus-client` based on the latest master branch which is fixed the derive macro bug: [ackintosh/client_rust@`into-metric`](https://github.com/ackintosh/client_rust/tree/into-metric) > > Now...