Thomas Eizinger
Thomas Eizinger
Have you read the error message? :) It tells you what the problem is: > Could not find `protoc` installation and this build crate cannot proceed without this knowledge. If...
Should we remove the `ProtocolName` abstraction as part of this or just change it to `&str` for now?
It is a fairly invasive change yes. Happy to mentor you along if you want to pick it up! See some of the communication in https://github.com/libp2p/rust-libp2p/pull/2798. I think we should...
Many abstractions that require `AsRef` currently may need to be changed to just use the new newtype.
In order to not have to decide between the two, we can have `Cow
@efarg Are you still working on this? I'd otherwise pick it up soon :)
Thanks for sharing! I'd tackle this from a different angle. Try and remove the `ProtocolName` trait first: https://github.com/libp2p/rust-libp2p/blob/2025de3ef0898ffa99545bd50aef868516c7f226/core/src/upgrade.rs#L123-L129 And replace `ProtocolName` here with a newtype: https://github.com/libp2p/rust-libp2p/blob/2025de3ef0898ffa99545bd50aef868516c7f226/core/src/upgrade.rs#L137-L147 The reason we need...
You are right, it can't be replaced 1 to 1! Essentially, removing `ProtocolName` from `UpgradeInfo` means that you can remove the `Info` associated type and just express `InfoIter`'s bound as:...
> @thomaseizinger sharing some progress. This patch gives 29 errors. I am thinking about how to solve them. > > https://paste.debian.net/hidden/3c3659e9/ Can you open it as a pull-request please? I'd...