Tommy Hofmann comments

Results 702 comments of


                                            Tommy Hofmann

feat: unundeprecate p- and q-adic methods

OK, makes sense, thans.

`QuadFormAndIsom`: Serialization infinite order isometries and a minor fix

Are you happy with this @antonydellavecchia?

Bibliography link anchors inconsistent

OK. Is this something we can fix with the style? PS: I still consider this a bug with how our bibliography looks like. Unless you are saying that we do...

Fix Oscar.build()

How long does that take to run typically? Maybe we can add a CI job to not break it again accidentally.

Fix Oscar.build()

> > How long does that take to run typically? > > With just the short tests, it takes ~40 minutes on my workstation (~30 minutes for the tests, ~10...

Unify style for 'recursive' kwarg

I want whitespaces around ` = `.

Implementation of the ring interface

Thanks @HechtiDerLachs for the feedback. Regarding the first point, I would also like to make it optional instead of mandatory. I see two options. 1. Just mark it as mandatory...

Implementation of the ring interface

The `test_Ring_interface` should test the `divexact`method in case it exists. One can use `if hasmethod(divexact, Tuple{T, T})` to check the existent of the method one wants to check.

Implementation of the ring interface

I also prefer option 2. Lots of things won't work if `divexact` is missing, but who cares. A lot of things will still be working and we will get some...

Reducing usage of or even removing `groebner_assure`, `oscar_assure`, `singular_assure`

Isn't this exactly what we did? The code you quoted is itself part of the `*_assure` function and it is called in the accessors here: https://github.com/oscar-system/Oscar.jl/blob/169ccdf41f7ac1a55e828530253aa215b1a11534/src/Rings/MPolyQuo.jl#L55-L58 And everywhere these accessors...