Oscar.jl icon indicating copy to clipboard operation
Oscar.jl copied to clipboard

`QuadFormAndIsom`: Serialization infinite order isometries and a minor fix

Open StevellM opened this issue 9 months ago • 1 comments

Up to now, since there is no serialization of PosInf, we could not store the order for isometries of infinite order. Since, in the finite or trivial case, this order n is at least -1, for the storing I have opted for n = -2 in the case of infinite order.

Eventually, even if we implement the serialization of infinity, I guess it could stay as is: there is no possible conflict, and it is something that humans are not suppose to read.

@antonydellavecchia does it seem good ? Any objection ?

The extra minor fix is trivial: OqAinOD, by construction, sends the identity to the identity (similarly for the other one).

StevellM avatar May 20 '24 13:05 StevellM