tgreenx

Zone files: ``` $TTL 3600 $ORIGIN recursor.xa. @ IN SOA ( ns1.xa. marc\.vanderwal.afnic.fr. 2023103100 86400 14400 3600000 3600 ) NS ns1.xa. NS ns2.xa. $ORIGIN good-cname.recursor.xa. target IN A 192.0.2.1 IN...

> What is the purpose of mixing case in > > ``` > illegal1 IN CNAME target0 > ILLEGAL1 IN CNAME target1 > ``` > > and others? Generally it...

> @tgreenx, How should the unit tests react on NODATA and NXDOMAIN responses, respectively? > > NODATA: > [...] > NXDOMAIN: > [...] CNAME evaluation will not be done in...

@matsduf This PR has been updated to include the change discussed in the work group, and rebased on latest develop. But currently two unit tests are failing due to what...

@matsduf @mattias-p I have addressed or responded to your comments. See commit https://github.com/zonemaster/zonemaster-engine/pull/1288/commits/132402960fcf0dc11e385d4f3ff4723e55349c47 - please re-review.

> How will the code react if the answer section has a CNAME pointing at a target name, but the `A` record has another owner name? > > ``` >...

@matsduf @mattias-p Comments are addressed, please re-review. See commit https://github.com/zonemaster/zonemaster-engine/pull/1288/commits/32244e921c92c095e1d814311feb011562dfdb2e.

@matsduf All comments have been addressed in https://github.com/zonemaster/zonemaster-engine/pull/1288/commits/5756f4951d9e452de8fc1bfe1e45fb8541750d50. Also note that with the removal of duplicate records all unit tests now work as expected too.

> @tgreenx, could we complete this together with [Test zones for the CNAME function in Recursor.pm in Engine](https://github.com/zonemaster/zonemaster/pull/1220)? Yes this should be finished in time.

@matsduf please re-review. I addressed your latest comment, and rebased on latest develop.