tgreenx

Results 178 comments of tgreenx

Specifications of test zones being added in https://github.com/zonemaster/zonemaster/pull/1254 Implementation of those test zones is done in https://github.com/zonemaster/zonemaster-engine/pull/1350

Solved in release v2024.2 by #1350

I don't think I agree with what is being asked here. From what I understand, "no_network" mode is a profile parameter which is only relevant when used with pre-recorded data,...

> > ``` > > * It updates profile parameters "asn_db.style" and "asn_db.sources" > > ``` > > Is that an update of documentation only, or functional update? Documentation only....

> No support for CNAME. So it seems that the [recursive lookup function](https://github.com/zonemaster/zonemaster-engine/blob/v4.7.2/lib/Zonemaster/Engine/Recursor.pm#L156-L227) of Zonemaster does not follow CNAMEs. It stops at the first satisfying response. I can update that...

> > No support for CNAME. > > So it seems that the [recursive lookup function](https://github.com/zonemaster/zonemaster-engine/blob/v4.7.2/lib/Zonemaster/Engine/Recursor.pm#L156-L227) of Zonemaster does not follow CNAMEs. It stops at the first satisfying response. I...

> I can update that but a lot of unit tests will break (due to missing data). But updating that data will also make a lot of them break, because...

@matsduf This PR has been rebased on latest updates from https://github.com/zonemaster/zonemaster-engine/pull/1288 (commit https://github.com/zonemaster/zonemaster-engine/pull/1257/commits/24f34518227556a566ab3cd13e82277032c7401a). For easier reviewing you can discard this commit. Please-re-review.

TODO in this PR: fix usage of `asn_db.sources` (see https://github.com/zonemaster/zonemaster-engine/pull/1311#issuecomment-1845380408)