Teun van den Brand

Results 172 issues of Teun van den Brand

This PR aims to fix #5212. Briefly, it adds more options for the `dir` argument to layout the panels in various ways. The `as.table` argument gets absorbed into `dir` when...

This PR aims to fix #5866. Briefly, a new helper function `ggpar()` is used to wrap `grid::gpar()` while applying ggplot's interpretation of graphical parameters. It simplifies several things: * We...

Throughout ggplot2's codebase, there are various calls to `grid::gpar()`. There are several operations that happen almost ubiquitously, like the following `gpar(lwd = len0_null(linewidth * .pt))`. The suggestion here is to...

internals :mag_right:

This PR aims to fix #5856. It just falls back to an empty `margin()` when it was not declared in the theme. Reprex from issue: ``` r devtools::load_all("~/packages/ggplot2/") #> ℹ...

This is a git cherry pick of the merge commit of #5781. Earlier, we decided to defer #5781 until after the 3.5.1 release. Marking this as draft until release is...

Currently we have the following parametrisation for rectangles: `geom_tile()` has `x`, `y`, `width` and `height`. `geom_rect()` has `xmin`, `xmax`, `ymin` and `ymax`. If you know two of the `x` or...

feature
layers :chart_with_upwards_trend:

This PR aims to fix #5809. Briefly, it adds an `orientation` argument to `position_dodge()` that can be set to `"y"` in order to dodge vertically if `has_flipped_aes()` cannot discern an...

This PR aims to fix #3825. Briefly, `?density` recommends the `"sj"` method over the `"nrd0"` default. This change propagates that recommendation to ggplot2's density calculations. Some details: * Understandably, plenty...

breaking change :skull_and_crossbones:

This PR aims to fix #5756. Briefly, it simply drops `NA` from limits before mapping, ensuring that only 'proper' values are matched. Reprex from issue: ``` r devtools::load_all("~/packages/ggplot2") #> ℹ...

This PR aims to fix #5485. Briefly, `ulevels()` was always dropping `NA`s, leading to data being mapped to non-existing PANELs and generating invalid `scale_id`s. By including `NA`s, we prevent these...