Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Thanks @benbowler, this is looking good. Once last thing - it would be good to give a bit of direction to encourage sharing more logic between the two `Request` classes....

Thanks Ben! IB LGTM :white_check_mark:

Hey @benbowler, thanks for drafting this IB. A few points: - The first report in `AudienceTiles` doesn't seem to need the update - it's already being retrieved via `getReport()` rather...

Thanks for the update @benbowler. It looks like these two points have been missed, though, please can you take a look? > - The report with options `topContentPageTitlesReportOptions` should also...

Thanks @ankitrox - in cases like this, we don't tend to wait for the dependency to go through QA, simply having it merged is enough to move this to CR....

Hi @ankitrox, I have left a few comments on the PR, please take a look. Additionally, reviewing the QAB I'd note that the code snippets aren't really needed - the...

Hey @kelvinballoo, what I'd suggest for the smoke test is to refer back to this [comment](https://github.com/google/site-kit-wp/issues/8763#issuecomment-2147935477) I left on #8763 where I point out that we can see the same...

## QA:Eng :x: While performing QA:Eng for this issue, I've had a horrible realisation that pivot reports aren't actually suitable for the audience tiles in the way we thought they...

Note that due to the above, this issue will be closed as "not planned" and not included in the forthcoming release.