Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Thanks @kelvinballoo and @nfmohit. Nahid, to answer your questions: > I felt the missing "to" was an overlook in the ACs, and I added it to complete the phrasing. @techanvil...

Unassigning @jimmymadon as he's on his break and this will be picked up by Squad 2.

Hey @hussain-t, please refer to Figma as the source of truth for designs unless explicitly stated otherwise in the design doc. As mention in the design doc under [**UI components**](https://docs.google.com/document/d/1MGD5Djy6AeeZC4zBtHqS-lQEWD9jw0kf-IIWw-jLCFU/edit#heading=h.r0ayq07z5cr0):...

Thanks @kuasha420! Back to you for another pass, @kelvinballoo.

Moved to Backlog until we get all the P1 issues done and/or the initial release out.

Thanks @benbowler, yep we should update this issue to account for any and all relevant new banners when we are ready to move it out of the Backlog.

Actually, I've realise this issue shouldn't be needed once all of the setup banners have been migrated to the new notifications infrastructure. Let's keep the issue open for now, as...

Thanks @benbowler, that sounds sensible! Regarding the IB, it's a good first take. However with the `runReport` and `runPivotReport` GA4 endpoints being two distinct entities, with similar yet crucially different...

Hey @benbowler! Indeed, I imagine it will result in a bit of duplicate boilerplate, but I'd hope we can avoid too much duplication of logic. Thanks for updating the IB,...

Thanks @benbowler! Just dropping a quick reply re. the date range comparisons. From what I can see, the reports we use `getReportForAllAudiences()` for, which are the ones we'll rewrite as...