Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Implement the OAuth flow for the Setup CTA Banner

Thanks @zutigrm! IB LGTM. :white_check_mark:

Implement the OAuth flow for the Setup CTA Banner

Hey @ankitrox, I've left a few comments on the PR. With regard to the QAB - although it could be enough to give the QA team sufficient direction, it would...

Implement the OAuth flow for the Setup CTA Banner

Thanks @ankitrox! As per my review comment, I am not seeing the updated version of the tests. Maybe you need to push a recent change?

Implement the OAuth flow for the Setup CTA Banner

No worries, thanks @ankitrox! As per my latest review this needs one more pass, please take a look.

Long post titles on the "Top content by pageviews" section of Audience tile occupies multiple line instead of sticking to single line with ellipses

Hey @ankitrox, please can you add a QAB for this one?

Long post titles on the "Top content by pageviews" section of Audience tile occupies multiple line instead of sticking to single line with ellipses

Thanks @ankitrox!

Long post titles on the "Top content by pageviews" section of Audience tile occupies multiple line instead of sticking to single line with ellipses

Back to you for another pass, @kelvinballoo!

Include Switzerland in Consent Mode regions from ~July 31st, 2024.

@aaemnnosttv we _could_ use the system date on the backend as the condition for this change. As you've pointed out we don't have the concept of a reference date on...

Include Switzerland in Consent Mode regions from ~July 31st, 2024.

Thanks @aaemnnosttv, SGTM. I've updated the AC here to specify using the date _or_ a new feature flag in the relevant condition. I've specified that we should use UTC midnight...

Include Switzerland in Consent Mode regions from ~July 31st, 2024.

IB :white_check_mark:, nice one @nfmohit!