Tom Rees-Herdman

Results 525 comments of Tom Rees-Herdman

Refactor the Key Metrics Selection Panel, extracting components for reuse in the Audience Segmentation Selection Panel.

Hi @ankitrox, thanks for drafting the IB/POC. It's definitely heading in the right direction, however there are a number of aspects I would like to see addressed. - We should...

Refactor the Key Metrics Selection Panel, extracting components for reuse in the Audience Segmentation Selection Panel.

Thanks @ankitrox, nice work here so far on the IB. I've made a few tweaks, to fix a couple of minor errors and remove some duplication, which you can see...

Refactor the Key Metrics Selection Panel, extracting components for reuse in the Audience Segmentation Selection Panel.

Thanks @ankitrox, that's great. IB LGTM! :white_check_mark:

Add Site Health section

Hi @ankitrox, thanks for drafting this IB. However, the approach you've suggested is not really necessary - we can add to the `Analytics_4::get_debug_fields()` method instead, where the other Analytics related...

Add Site Health section

Thanks @ankitrox, this is looking better, one thing though - we try to avoid including literal code blocks in IBs. I would say this IB can be written without the...

Add Site Health section

Thanks @ankitrox! I've made some additional changes to the IB. Notably I've removed the explicit definition for the new method and left this optional, and also removed the point about...

Add Site Health section

Hi @ankitrox, as well as addressing the feedback left on the PR, please can you update the QAB for this issue as follows: - Rather than providing an audience configuration...

Add Site Health section

Thanks @ankitrox! I've left a few further comments on the PR, please take a look. I've also tweaked the code example in the QAB slightly to follow our usual naming...

Add Site Health section

Thanks @ankitrox! The PR needs one last update and this should be good to go.

Rewrite reducers to use Immer.

Thanks @aaemnnosttv, that makes sense. However, as I've not been able to get to this for a while, I've unassigned it so someone else can pick it up if they...