Yat Ho

Results 355 comments of Yat Ho

(1) and (2) looks to be the same argument worded differently. Regardless, I agree with them. (3) is a valid problem that needs to be addressed. (4) is unrelated, `tr_peerIo::is_seed_`...

I also found an inconsistency in the process to find peer candidates. On the swarm level, Tr is allowed to connect to seeds even if it itself is a seed,...

See what you think. ```patch diff --git a/libtransmission/peer-mgr.h b/libtransmission/peer-mgr.h index 7c0b4915c..a32c80be5 100644 --- a/libtransmission/peer-mgr.h +++ b/libtransmission/peer-mgr.h @@ -207,9 +207,16 @@ public: if (is_connected_) { - num_consecutive_fails_ = {}; piece_data_at_ =...

We need to keep these seeds in the candidate list, and somehow discourage ourselves from trying them. Or else, we will rediscover these peers from trackers and whatnot sooner or...

I am having a really hard time understanding this issue... Please bear with me here. And although you didn't specify, from your past posts, I am guessing you are using...

> The docs specifically say `KBps` which is neither `kB/s` nor `KiB/s`. Sounds to me the confusion primarily came from the docs not using standard units (i.e. KBps), why not...

I think a more appropriate thing to do is to add a new datetime stat that tracks download activity. In any case, I disagree with the current change, it makes...

A bit related - We are not running clang-tidy on the utils. (`transmission-remote` etc.)

AFAICT Transmission's RPC server doesn't return 403. Are you behind a reverse proxy, or are you adding the torrent via an URL?