Yat Ho

Results 355 comments of Yat Ho

Anything you want to bring over from your PR?

1. Done, but I didn't early return like you did. 2. Done. > But leaves open question: should outbound `send_ut_pex()` happen once before setting up the pex timer? Yes, no...

@reardonia I've split out the log changes to #7203, and the LTEP flag change to #7204.

@reardonia An approve if you have nothing else to comment please? :)

Sorry, I must have missed it. I am only seeing your latest review comment talking about ut_pex_id and ut_metadata_id. If there's another comment talking about them from before, could you...

Putting aside the difficulty of implementing 2 interfaces for now, would it work for you if the new "standard" RPC API uses the new snake_case keys, while the existing API...

Those are all unreleased fields, so there's no backward-compatibility issue.

> does this mean anyone who upgrades to Transmission 4.1 won't be able to go back to 4.0.x without breaking their data files? @ckerr Yes. > instead of prettifying existing...

@ckerr I'm going to try implement JSON-RPC in this PR on top of the current changes. Let me know if you want those changes in a separate PR. 🫡

> This PR is a monster. 👹 I'm going to need to review it in chunks. @ckerr This PR ***is*** huge, but iirc almost half of the diff you are...