Yat Ho
Yat Ho
> No idea about Mac re. systems support. `std::view` needs Xcode 14.3, and that's gonna bump the build requirement all the way from macOS 10.14.6 to 13. So that's not...
I think we can bump it any time now, and gradually use more C++20 features as compiler support improves. We have the CI to check unsupported features after all.
Anybody know of a webseed I can test this PR with? The webseeds provided by the issue either isn't working anymore, or is not corrupt.
It has to be webseeds that distribute corrupt data.
Finished testing, looks to be working as intended. ``` [2024-06-12 07:24:04.768] trc test.dat increasing peer localhost:80 strike count to 1 (peer-mgr.cc:646) [2024-06-12 07:24:04.768] trc test.dat increasing peer localhost:80 strike count...
There was a discussion about how long do we keep supporting `4.0.x`. If that still holds, then the next release should be `4.1.0-beta1`, and there will be no more `4.0.x`...
You might be worried because `notify_bandwidth_consumed()` is a recursive function, but the depth will at most be 2-3 levels in practice, so it is still cheap. Same goes for `clamp()`.
Did you also apply the refactor to remove the loop in `tr_handshake::can_read()`? It's not just a code cleanup, it is needed for this fix.
Well, from this log I got, looks like it works just fine though... This is from https://github.com/tearfur/transmission/tree/tmp, where I rebased 6891, this PR and 6917 on top of eacher other....