Yat Ho
Yat Ho
Rebased to `main` with autosquash.
> `pex_flags_` is just meant to represent the most recent PEX flags that we received, by whatever mechanism. It doesn't actually change the internal flags in `tr_peer_info`; `pex_flags()` will generate...
The reason for `ia_len_ > 0U` is because as long as even one byte of the handshake was sent within `IA` by "A", then as "B", the check `peer_io->read_buffer_starts_with(HandshakeName)` won't...
The test handshake timed out after 5 seconds... This change alone can't make that happen. Did you make your own local patch or run the test with breakpoints? Also the...
> How do I do that? Do you just mean run within gdb? if so, how? What I mean was, if you *were* running with breakpoints, and paused for 5...
> is that just the effect of "result" never being set/returned from the handshake? Yes. > sorry to ask general questions like this within a specific issue (wish we had...
> Do you think it's better to track and maintain priorization as peers are added, or to just do it on one batch when we are culling and/or saving peers...
Still need to update Xcode project and change submodule to Transmission's fork of the crc32-c library.
@ckerr Could you please help fork the CRC32C repository? Also if somebody can help update the Xcode project to include the new submodule, that'd be great.
I'm waiting for the Xcode build fix from @nevack, as I don't have a Mac. The PR is ready otherwise.