Yat Ho

Results 355 comments of Yat Ho

> EDIT: sorry, wasn't testing with #6917 as well. Will retry the combo now. I don't think 6917 is needed for this fix... But anyway, let me try do some...

Any previous PR approvals are now no longer valid because I decided to backtrack on the previous fix and keep the loop in `tr_handshake::can_read`. The reason for that is because...

> title should say "downloaderCount" not "downloadCount" Whoops.

Renamed the new parameter to snake_case.

I remember seeing some classes that didn't need a default constructor end up having one anyway to workaround this `small` bug. So IMO this should be merged asap so we...

Huh, their previous releases are on the `develop` branch, so I just assumed that it's the same for `v0.2.2` too. Now updated the submodule to the release tag.

1. Feel free to read `tr_peer_info::pex_flags()` and `tr_peer_info::set_pex_flags()` to convince yourself that setting `is_seed_` is equivalent to setting `ADDED_F_SEED_FLAG`. 2. Good point. ad8f09288bd58b232ef088985021dcab595c6002 3. Those that triggers `publish()` means that...

> I am rethinking whether it was a good idea to filter out peers that weren't marked as connectable in `tr_peerMgrAddPex()`. If the peer turned out to be not very...

That wasn't intentional, should be fixed now in bdc29bb.