Timothy Meehan

Results 89 comments of Timothy Meehan

@imjalpreet it looks like there are test failures

> Hey @tdcmeehan, any suggestions on Jalpreet's question? @imjalpreet and I discussed on Slack and he will be figuring out a path forward.

Anyone who extends the JDBC connector may have a dependency on those types. Why delete them?

@pratyakshsharma please fix the merge conflicts, thanks!

Going to merge this tomorrow if there's no further objections, thanks!

@v-jizhang the test failure looks related, could you have a quick look?

Thank you for refactoring this into a plugin. Can you please make sure that all the file-based loading code is in one module, and all the core code to wire...

@m1n0 can you please ask for help in the PrestoDB Slack to get this PR moving? I am not a Python expert, but I can help provide a surface review...

@yulongfufu the information here would be great to merge back into trunk. Is this waiting review still?

@NikhilCollooru I am going to take over this review. Please, if you have any feedback, let us know.