presto-python-client icon indicating copy to clipboard operation
presto-python-client copied to clipboard

Published 20 hours ago • verified publisher icon prestodb

Support decimal and time data types

Open m1n0 opened this issue 1 year ago • 7 comments

This is roughly a copy of what Trino did here https://github.com/trinodb/trino-python-client/pull/160 - with two exceptions:

  • no tests - I dont see dbapi tests in general in this repo
  • I added the experimental boolean flag to the connection itself, that seems to make more sense to me rather than adding it to the cursor.

m1n0 avatar Oct 13 '23 21:10 m1n0

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: m1n0 / name: Milan Lukac (90944f0860e0c5a32cea5a38b1f8f31e76c6fe08)

linux-foundation-easycla[bot] avatar Oct 13 '23 21:10 linux-foundation-easycla[bot]

is there something blocking this @tdcmeehan ?

m1n0 avatar Oct 31 '23 10:10 m1n0

@m1n0 can you please ask for help in the PrestoDB Slack to get this PR moving? I am not a Python expert, but I can help provide a surface review later.

tdcmeehan avatar Nov 28 '23 18:11 tdcmeehan

thanks for the comment @tdcmeehan ! I already did that when I opened the PR, I just asked again now.

m1n0 avatar Dec 13 '23 01:12 m1n0

I can deploy a cluster in AWS and let you try this out.

wanglinsong avatar Dec 13 '23 03:12 wanglinsong

hi, what can I do to move this forward?

m1n0 avatar Apr 29 '24 18:04 m1n0

hi, what can I do to move this forward?

Please run some BAT tests to make sure the new updates work. You can deploy a local cluster, or I can provide one.

wanglinsong avatar Apr 29 '24 18:04 wanglinsong