presto
presto copied to clipboard
Removed unsupported data types on read/write paths in jdbc connectors
Cherrypick of https://github.com/prestodb/presto/pull/12231/commits Test plan - (Please fill in how you tested your changes)
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.
Fill in the release notes towards the bottom of the PR description. See Release Notes Guidelines for details.
== RELEASE NOTES ==
General Changes
* QueryBuilder and BaseJdbcClient see the changes
*
If release note is NOT required, use:
== NO RELEASE NOTE ==
@NikhilCollooru Can you please take a pass.
I am on parental leave. May be @highker can help review.
There is no harm to keep it around right?
We actually have dependency of this client to fall back from TIMESTAMP_WITH_TIME_ZONE
to TIMESTAMP
(or TIME_WITH_TIME_ZONE
to TIME
). Deleting these two types could cause regression.
We actually have dependency of this client to fall back from TIMESTAMP_WITH_TIME_ZONE to TIMESTAMP (or TIME_WITH_TIME_ZONE to TIME). Deleting these two types could cause regression.
@highker Where do we have this dependency? Can you point me to the relevant files?
@highker ping.
Anyone who extends the JDBC connector may have a dependency on those types. Why delete them?
Got you, closing this PR. Thank you for reviewing.