presto icon indicating copy to clipboard operation
presto copied to clipboard

Removed presto-geospatial module and moved the types and functions to presto-main

Open pratyakshsharma opened this issue 2 years ago • 5 comments

Relevant slack discussion here - https://prestodb.slack.com/archives/C07JH9WMQ/p1651146423521239

Test plan - (Please fill in how you tested your changes)

Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.

Fill in the release notes towards the bottom of the PR description. See Release Notes Guidelines for details.

== RELEASE NOTES ==

General Changes
* Removed presto-geospatial module 
* Added the types and SqlFunctions defined by GeoPlugin to `BuiltInTypeAndFunctionNamespaceManager.java` for registering
* Moved the relevant classes to presto-main to avoid too many circular dependency issues which would have occurred if movement was done to presto-common rather
* Moved the relevant test classes to presto-main and presto-memory

pratyakshsharma avatar Jun 24 '22 12:06 pratyakshsharma

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: pratyakshsharma / name: Pratyaksh Sharma (3614ccb8e5a165d707f946567d6965c2ca9e1a75)

@fgwang7w please take a look and add any relevant stakeholders.

cc @imjalpreet @agrawalreetika

pratyakshsharma avatar Jun 24 '22 12:06 pratyakshsharma

Hi @zhenxiao I've given 1st pass of code review, please help review as well. Hi @tdcmeehan This is a straight forward lib moving from one module to presto-main, I suppose there's a need to document the changes for release notes, any suggestion? Thanks

fgwang7w avatar Jun 29 '22 01:06 fgwang7w

@zhenxiao @tdcmeehan ping!

pratyakshsharma avatar Jul 14 '22 08:07 pratyakshsharma

@pratyakshsharma please fix the merge conflicts, thanks!

tdcmeehan avatar Jul 21 '22 19:07 tdcmeehan

fixed the merge conflicts. Verified the changes using show functions; command and by invoking few simple functions as in the attached screenshot Screenshot 2022-08-17 at 10 11 45 PM .

pratyakshsharma avatar Aug 17 '22 16:08 pratyakshsharma

@tdcmeehan let us merge this!

pratyakshsharma avatar Aug 17 '22 18:08 pratyakshsharma

The release notes are not user facing. What should the user do ? User need not register GeoPlugin anymore if I understand it correctly. Can you please give me an updated release note ?

arunthirupathi avatar Aug 24 '22 01:08 arunthirupathi

@arunthirupathi sure. Actually the user facing release notes are present in the commit message body. Providing them as below -

  1. presto-geospatial module has been removed and GeoPlugin class has been deleted.
  2. User does not need to do anything now to make use of presto's geospatial functions. All the functions are auto registered, one can simply start using them after starting the server.

Does this look good?

pratyakshsharma avatar Aug 25 '22 20:08 pratyakshsharma