Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

doc: split supported platforms table

ping @mmarchini

refactor: undefined check for tls_wrap

Do we need a new benchmark run?

benchmark: add benchmark groups

@nodejs/benchmarking

Zlib: brotli compression is much slower than gzip

The results don't seem unexpected to me. The [brotli repository](https://github.com/google/brotli) points to the following site for benchmarks, where the difference between brotli and gzip is similar: http://mattmahoney.net/dc/text.html

Broken `test/v8-updates/test-linux-perf-logger`

Yes, it would be very helpful! Note that the test was just [skipped in CI yesterday](https://github.com/nodejs/node/pull/52821) so a fixing PR would have to re-enable it. I'm not sure why you...

Broken `test/v8-updates/test-linux-perf-logger`

Ah no, it's an old run that's not available anymore. Try https://ci.nodejs.org/job/node-test-commit-v8-linux/5954/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console

regression in 21.4.0 when using `esm` package

This is from https://github.com/nodejs/node/pull/50907 /cc @ronag @anonrig

`assert.ok()` throwing `AssertionError` instead of provided `Error` object

We could use the same algorithm as `util.isError`: https://github.com/nodejs/node/blob/1858341377c268c5ffce9345517dc07b0e6c240a/lib/util.js#L167-L169

`assert.ok()` throwing `AssertionError` instead of provided `Error` object

The function is deprecated, but not what it does. It works fine with child classes.

`assert.ok()` throwing `AssertionError` instead of provided `Error` object

If you don't believe me, try it