Michaël Zasso

Issue should be fixed in the next minor version of VS2022: https://developercommunity.visualstudio.com/t/cpp20-nested-namespace-cant-compile/10328893#T-ND10330571

Yes, if you want to keep the original change on `main`

References: https://github.com/nodejs/node/blob/d65514bc29ff4e91ae560884d10483e33012e095/deps/v8/src/heap/heap.cc#L239-L254 https://github.com/nodejs/node/blob/d65514bc29ff4e91ae560884d10483e33012e095/deps/v8/test/unittests/heap/heap-unittest.cc#L77-L97

With all the above hacks, I am blocked on this error: ``` lld-link : error : undefined symbol: public: virtual __cdecl v8::internal::Relocatable::~Relocatable(void) [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj] ``` Related warning in the build output:...

/cc @nodejs/v8

Rebased on https://github.com/nodejs/node/pull/35700

I don't know if CI has clang-cl. Let's try: https://ci.nodejs.org/job/node-test-commit-windows-fanned/38888/ Edit: well, it doesn't 😄 ``` 08:23:59 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppBuild.targets(411,5): error MSB8020: The build tools for ClangCL (Platform...

@nodejs/build-infra Would it be easy to install ClangCL build tools on the Windows machines?

So I tried to build it on my local machine. There's one warning that is very noisy (I think it's printed for every V8 source file: ``` ..\..\deps\v8\src/base/safe_conversions_impl.h(158,46): warning :...

Rebased. Failures are still the same: ``` lld-link : error : undefined symbol: public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int) const [D:\Git\nodejs\node\tools\v8_gypfiles\mksnapshot.vcxproj ] >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-aix.obj >>> referenced by ..\..\out\Release\obj\mksnapshot\\deps\v8\src\snapshot\embedded\platform-embedded-file-writer-generic.obj >>>...