Michaël Zasso
Michaël Zasso
I think the main issue with this feature is that we don't have an active collaborator who understands and maintains it.
It's not for moving files' sake if the goal is to open another PR later that uses the extracted internals.
It breaks a some high-impact packages in citgm.
Can you add https://github.com/nodejs/node/pull/52767 ? At the same time, you can amend the commit message to add the PR-URL.
@nodejs/vm
/cc @nodejs/cpp-reviewers
I understand why it happens: - `Object.has` calls our `PropertyGetterCallback` interceptor - We call `GetRealNamedProperty`, which follows the prototype chain https://github.com/nodejs/node/blob/6aa9047f960e2385dac807e0661a159324b00b0f/src/node_contextify.cc#L477-L478 I don't know how to fix it though. There...
Maybe the solution is to set a NamedPropertyQueryCallback (we currently don't).
We should also be careful about the impact. We don't want everyone to suddenly have 500 new notifications.
@nodejs/loaders