Michaël Zasso

Results 1686 comments of Michaël Zasso

It's about auditability. I didn't think of `process.permission.has()`. Maybe diagnostics channels are enough for this use case (assuming a malicious actor cannot alter its behavior to hide their activity).

Edit: was already mentioned [above](https://github.com/nodejs/node/issues/41521#issuecomment-1013156154) > I have no need for supporting `file://` strings. > > What I would like is: > > ```js > export const from = urlOrPath...

LGTM, but I propose an alternative, which contains the official V8 cherry-pick (https://github.com/v8/v8/commit/45e33e25713161cf67a6389880590848fdeed99f): https://github.com/nodejs/node/pull/45997

Can you please make a standalone commit for the changes in deps/v8 and common.gypi? We must be able to cherry-pick it easily during V8 updates. > As a rule we...

@kvakil is there a chance you'll continue this PR? I think it may fix a problem introduced with V8 11.5: https://github.com/nodejs/node/pull/48456#issuecomment-1591050515

The problem is that the V8 changes break V8 CI

I suppose we also need to adapt BUILD.gn (for the include dir)

The diff in https://github.com/nodejs/node/commit/f2651a0812ec2f7eb0c29f20669bd942e2e47258 doesn't look right. Only `wpt/url` is updated. We shouldn't see that many changes in `test/fixtures/wpt/README.md` and `test/fixtures/wpt/versions.json` See original commit: https://github.com/nodejs/node/commit/f2651a0812ec2f7eb0c29f20669bd942e2e47258

It should help to cherry pick these two first: https://github.com/nodejs/node/commit/f652f7baa6a59f0ec79b21668332c2c825d7b4d8 https://github.com/nodejs/node/commit/843856ead771a2db21d63f65eb1d52ddb264d9dd

FWIW I opened an issue about this in the docker-node repo: https://github.com/nodejs/docker-node/issues/1918 TLDR: this is not a problem with Node.js itself, but with the default base OS used by the...