util: move deprecated utils to eol

[marco-ippolito]

We are moving all the deprecated utils function to End Of Life

[benjamingr]

Also cc @nodejs/tsc since this can break stuf

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58793/ 🟢 CITGM: https://ci.nodejs.org/job/citgm-smoker/3423/

[marco-ippolito]

We may want to mention a migration path or polyfill for when this lands in v23.

e.g. a codemod or some such to rewrite code using stuff like util.isNull

I'll add notable change then so we can mention the migration path in the changelog

[github-actions[bot]]

The https://github.com/nodejs/node/labels/notable-change label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[targos]

It breaks a some high-impact packages in citgm.

[marco-ippolito]

At first glance it seems the failures are all related to debug and form-data Broken packages:

util._extend:

• is-core-module v2.13.1 (from debug as dev-dependency)
• minimist v1.2.8 (from debug as dev-dependency)
• leveldown v6.1.1 (from debug as dev-dependency)
• tape v5.7.5 (from debug as dev-dependency)

It seemed actually debug migrated away from _extend https://github.com/debug-js/debug/commit/1351d2f91f20da46316be67265216761548db53c and some libraries in the tree are still using a very old version

util.isArray:

• multer v1.4.5-lts.1 (from form-data as dev-dependency)
• fastify v4.26.2 (from form-data as dev-dependency)

[marco-ippolito]

after discussing with @mcollina I think it would be better not to EOL util.isArray until we can land the patch on form-data https://github.com/form-data/form-data/pull/564 Do not merge till I drop the commit

[marco-ippolito]

should be good to go, please review again as I went through a nasty rebase

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58829/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58860/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/58901/