Michaël Zasso
Michaël Zasso
Yes, on all release lines
Instead, I think we should look into using GitHub's commit queue system (which I think can ensure that tests pass after applying the commits in order).
The changes you did are under `#if HAVE_INSPECTOR`, so I guess these jobs don't enable the inspector.
Updated https://github.com/nodejs/node/pull/54536/commits/d73e7103f94592234df6146d0ce417163a6bcbc9 to fix the MSVC error. Opened https://chromium-review.googlesource.com/c/v8/v8/+/5805956 upstream to fix the macOS Clang error.
@nodejs/platform-aix Can you have a look at https://ci.nodejs.org/job/node-test-commit-aix/53241/nodes=aix72-ppc64/console ?
https://ci.nodejs.org/job/node-test-commit-osx/60761/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/65162/ https://ci.nodejs.org/job/node-compile-windows-debug/23534/
https://ci.nodejs.org/job/node-test-commit-osx/60768/
@nodejs/platform-windows, somehow Windows debug builds are broken. I tried two runs to be sure, but they both ended up in a timeout while building an addon: https://ci.nodejs.org/job/node-compile-windows-debug/23534/nodes=win-vs2022/console
Oh yes, I remember it! I opened an issue upstream: https://issues.chromium.org/issues/336349658 My workaround for the previous V8 update was to revert the change (https://github.com/nodejs/node/commit/16c9348e6089238cf266aa2dedf678a7729687a4), but I forgot that I had...