node icon indicating copy to clipboard operation
node copied to clipboard

deps: patch V8 to 12.8.374.22

Open nodejs-github-bot opened this issue 1 year ago • 11 comments

This is an automated patch update of V8 to 12.8.374.22.

nodejs-github-bot avatar Aug 18 '24 00:08 nodejs-github-bot

Review requested:

  • [ ] @nodejs/security-wg
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Aug 18 '24 00:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61193/

nodejs-github-bot avatar Aug 18 '24 13:08 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6140/

nodejs-github-bot avatar Aug 18 '24 13:08 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6140/

nodejs-github-bot avatar Aug 18 '24 13:08 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6140/

nodejs-github-bot avatar Aug 18 '24 13:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61409/

nodejs-github-bot avatar Aug 24 '24 11:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61470/

nodejs-github-bot avatar Aug 26 '24 06:08 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6153/

nodejs-github-bot avatar Aug 26 '24 06:08 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6153/

nodejs-github-bot avatar Aug 26 '24 06:08 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6153/

nodejs-github-bot avatar Aug 26 '24 06:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/61561/

nodejs-github-bot avatar Aug 27 '24 16:08 nodejs-github-bot

This was closed because the update script failed with a zero exit code: https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967

Run ./tools/dep_updaters/update-v8-patch.sh > temp-output
Error: spawn git ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:1[9](https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967#step:7:10))
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn git',
  path: 'git',
  spawnargs: [ 'fetch', 'origin' ]
}
✖ Do minor update to [12](https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967#step:7:13).8.374.26 [FAILED: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess]
✖ Minor V8 update [FAILED: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess]
✖ The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess
All done!

targos avatar Sep 01 '24 07:09 targos

I opened https://github.com/nodejs/node-core-utils/issues/850

targos avatar Sep 01 '24 07:09 targos

Landed in 0c771c35fad1867d016d54dfdf018a219a4a0718 (CI was green before the workflow deleted the branch).

targos avatar Sep 01 '24 07:09 targos

Should this be marked as dont-land?

aduh95 avatar Sep 12 '24 08:09 aduh95

Yes, on all release lines

targos avatar Sep 12 '24 09:09 targos