Michaël Zasso

Results 1686 comments of Michaël Zasso

+1, but I am very much against JSON for the format, mainly because it doesn't support comments.

Using a field in `package.json` to opt in sounds like a very good idea! We could allow a string to point to a specific file, or a boolean to load...

> Maybe something we can do is to support multiple formats (like what eslint does), and JSON would be the first to support SGTM

They would live relative to the package.json file that defines them or at an absolute pas if the reference is absolute.

> > @ronag would you mind sharing a use case for this method? Does [nodejs.org/api/n-api.html#napi_create_typedarray](https://nodejs.org/api/n-api.html#napi_create_typedarray) work for the use case? > > We talked about this in Node-API meeting, a...

This is a special case where after a few type checks it directly creates a `FastBuffer`

The test doesn't pass on v20.x-staging, so it will need a manual backport: ``` $ ./node test/parallel/test-buffer-tostring-range.js node:internal/errors:541 throw error; ^ RangeError [ERR_OUT_OF_RANGE]: The value of "size" is out of...

This was closed because the update script failed with a zero exit code: https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967 ``` Run ./tools/dep_updaters/update-v8-patch.sh > temp-output Error: spawn git ENOENT at ChildProcess._handle.onexit (node:internal/child_process:286:1[9](https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967#step:7:10)) at onErrorNT (node:internal/child_process:484:16) at...

I opened https://github.com/nodejs/node-core-utils/issues/850

Landed in 0c771c35fad1867d016d54dfdf018a219a4a0718 (CI was green before the workflow deleted the branch).