Michaël Zasso

Results 1686 comments of Michaël Zasso

I marked https://github.com/nodejs/node/pull/54418 dont-land

Behavior comes from: https://github.com/nodejs/node/blob/bae14b7914624630c3e451def82a8f56c6402534/lib/buffer.js#L476-L505 `byteOffset` and `length` are initially `undefined`, but the function ensures they are numbers, and if they are specified, the typed array's length stays fixed. /cc @nodejs/buffer

That was fixed by https://github.com/nodejs/node/commit/05bd3cfc73c0200a905d78c62a80edd85ba879e1 on `main`

^ That's https://github.com/nodejs/node/issues/51308

Maybe it's flaky, but I have never seen it pass myself.

Two win2019 machines are also affected: https://ci.nodejs.org/computer/test-rackspace-win2019_vs2019-x64-1/builds https://ci.nodejs.org/computer/test-rackspace-win2019_vs2019-x64-2/builds

Label added back to https://ci.nodejs.org/computer/test-rackspace-win2022_vs2022-x64-6/configure

@StefanStojanovic It seems the bug is still here: https://ci.nodejs.org/job/node-compile-windows/53041/nodes=win-vs2022-arm64/console

Removed ` win-vs2022-arm64` label from https://ci.nodejs.org/computer/test%2Drackspace%2Dwin2022%5Fvs2022%2Dx64%2D1/configure