nodejs
cli: add `--heap-prof` flag available to `NODE_OPTIONS`
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.41%. Comparing base (
10addb0) to head (86cd89b). Report is 40 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54259 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 652 652
Lines 186864 186878 +14
Branches 36064 36065 +1
=======================================
+ Hits 165217 165234 +17
- Misses 14888 14891 +3
+ Partials 6759 6753 -6
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/node_options.cc | 87.40% <ø> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Not sure why https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_withoutssl_x64/45126/ failed and the rest of the platform passed the tests affected by this patch. Will retry rn (it may be a cache at compile time issue)
I give up on this one. Looks like the linux-containered job is not building the latest changes. Maybe someone from @nodejs/build could give me a hand on this?
The changes you did are under #if HAVE_INSPECTOR, so I guess these jobs don't enable the inspector.
The changes you did are under
#if HAVE_INSPECTOR, so I guess these jobs don't enable the inspector.
Specifically, the inspector isn't available without SSL support.
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@juanarbol There hasn't been any activity on this PR in a while, and there are comments that need to be addressed before it can land, so I've marked it as stalled
Commit Queue failed
- Loading data for nodejs/node/pull/54259 ✔ Done loading data for nodejs/node/pull/54259 ----------------------------------- PR info ------------------------------------ Title cli: add `--heap-prof` flag available to `NODE_OPTIONS` (#54259) Author Juan José <[email protected]> (@juanarbol) Branch juanarbol:juan/heap-proof -> nodejs:main Labels cli, author ready, needs-ci Commits 1 - cli: add `--heap-prof` flag available to `NODE_OPTIONS` Committers 1 - Juan José Arboleda <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54259 Fixes: https://github.com/nodejs/node/issues/54257 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54259 Fixes: https://github.com/nodejs/node/issues/54257 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - cli: add `--heap-prof` flag available to `NODE_OPTIONS` ℹ This PR was created on Wed, 07 Aug 2024 23:37:44 GMT ✔ Approvals: 3 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/54259#pullrequestreview-2226360285 ✔ - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/54259#pullrequestreview-2228987134 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54259#pullrequestreview-2231718770 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-15T00:34:10Z: https://ci.nodejs.org/job/node-test-pull-request/63106/ - Querying data for job/node-test-pull-request/63106/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11340145799