Taiki Endo

Results 938 comments of Taiki Endo

Alternatively, we might want to allow custom fallback implementation.

> @taiki-e Is this failure a result of the cross tool chain action? Rust 1.78 contains changes that cause compatibility issues with older wine/mingw toolchains. (e.g., https://github.com/rust-lang/rust/issues/123999 https://github.com/rust-lang/rust/issues/122228) Removing the...

Published in 3.8.0.

Thanks for the PR. It seems that Miri and sanitizer reports memory leak: https://github.com/crossbeam-rs/crossbeam/actions/runs/12221429705/job/34090460906?pr=1121#step:4:168 https://github.com/crossbeam-rs/crossbeam/actions/runs/12221429705/job/34090462020?pr=1121#step:5:186

@driftluo > The memory leak reported by miri is the `panic_on_drop` test case, which seems to be the expected behavior, because https://github.com/rust-lang/rust/blob/master/library/std/src/sync/mpmc/array.rs#L487-L489 The comment here indicates that if there is...

> ensuring that values don't _cross_ a cache line Given how we set our aarch64 and x86_64's alignments, I don't think this implementation is sufficient. I'm also interested in what...

This is not blocked on MSRV. On older versions, Cargo just outputting a warning that is not promoted to an error as well as the `rust-version` field. ``` warning: /home/runner/work/tokio/tokio/Cargo.toml:...

Thanks for the PR. I would prefer to forward the necessary methods rather than allow arbitrary access.

Thanks for the report! It looks like there is some kind of problem with the path handling in Windows. Could you provide an example that can reproduce the problem?

> it does not poll the inner future until the `Shared` it creates is polled. [`std::future::Future` docs say](https://doc.rust-lang.org/stable/std/future/trait.Future.html#runtime-characteristics): > Futures alone are *inert*; they must be *actively* `poll`ed to make...