Taiki Endo

Results 938 comments of Taiki Endo

I thought `working-directory:` could be used together with `uses:`, is that not so?

Ok, if the native `working-directory` option cannot be used, I would accept a PR to add a `working-directory` input option.

Ok, here is experimental support for signing with PGP: https://github.com/taiki-e/upload-rust-binary-action/compare/main...pgp Here is a workflow example: ```yaml - uses: taiki-e/upload-rust-binary-action@pgp with: bin: ... # Public key used for PGP signing. #...

Yeah, install-action also supports that. Its interface is simple, so could probably be implemented with only a few adjustments and simplification of the implementation for PGP.

UPD: codesign on macOS was supported in 1.18.0 (#61) about a month ago.

I believe we can support minisign by tweaking [my PGP patch above](https://github.com/taiki-e/upload-rust-binary-action/issues/40#issuecomment-1382745575) a bit, so that would be the best way to do it.

Do you mean that the [normal way of cross-compiling](https://github.com/taiki-e/upload-rust-binary-action?tab=readme-ov-file#example-workflow-cross-compilation) didn't work? (cross supports android)

Ok. I would accept a PR to add support for the new cross-compilation tool. See https://github.com/taiki-e/upload-rust-binary-action/pull/50 for an example of adding support for the new cross-compilation tool.

Is the actual request here to add an option to support split-debuginfo? Or is it to add an option to not strip? In the former case, specifying split-debuginfo in the...

So the actual request is the latter (add an option to not strip)?