Taiki Endo

Results 938 comments of Taiki Endo

Doing nothing unless polled is the normal behavior of futures, so I don't feel the need to add the same explanation to each individual future about it. (Or am I...

- [as_mut_ptr is an unstable API](https://doc.rust-lang.org/std/sync/atomic/struct.AtomicUsize.html#method.as_mut_ptr), and loom does not usually attempt to emulate unstable APIs. - Even if loom provides as_mut_ptr, I think the use of as_mut_ptr in your...

No. When loom's atomic type is freed, the value is also freed, so there is only one pointer that needs to be freed. However, you need to call `Box::from_raw*` with...

> SIGABRT: process abort signal I think this is due to panic during panic as well as https://github.com/tokio-rs/loom/issues/291.

This is essentially the same issue as https://github.com/taiki-e/cargo-llvm-cov/issues/8#issuecomment-855198941. And it is also related to https://github.com/taiki-e/cargo-llvm-cov/issues/43 in that the summary output of `llvm-cov` is not very configurable. That said, this is...

I would accept a PR to support this. See [DEVELOPMENT.md](https://github.com/taiki-e/install-action/blob/main/DEVELOPMENT.md) for how to add support for a new tool.

Hmm. Ideally, this should be handled on the rustc or LLVM side, but it is probably not easy, so I'm open to providing a workaround on the cargo-llvm-cov side, but...

As said in https://github.com/taiki-e/cargo-llvm-cov/issues/341#issuecomment-1900629918, this should be fixed by fixing our demangler implementation.

This probably has been fixed in v0.6.7 (https://github.com/taiki-e/cargo-llvm-cov/pull/354). Could you recheck this with v0.6.7?

If lcov (or what you are using) doesn't support demangling of rust symbol, it is expected result, at least with the current implementation. We currently doesn't pass `-Xdemangler` to `llvm-cov...