Taiki Endo
Taiki Endo
Hmm, since mfence does the serialization, the previous cache should not be available for the load from r15+0x80 (i.e., self.tail), but I thought the load from r15+0x190 was the access...
Is this the same as the already merged https://github.com/crossbeam-rs/crossbeam/pull/1132? Or are you requesting something different?
@matthew-mcallister Thanks for the explanation. I think if we do this before (unreleased) https://github.com/crossbeam-rs/crossbeam/pull/1132 is released, we can put in this without a breaking change using the default type parameter,...
> I also forked a version of `crossbeam-skiplist` (https://docs.rs/crossbeam-skiplist-fd/0.1.5) to support custom comparators several months ago. Um, that crate has 9 traits in comparison related...? If they are really needed...
Does https://github.com/tokio-rs/async-stream/issues/68 's trick work? In any case, https://github.com/tokio-rs/async-stream/pull/74 should solve this issue.
Unfortunately, the proposed API does not work well because specific environment variables must also be set at runtime. The way it is currently available for this kind of use case...
@wiktor-k Does `cargo llvm-cov run --no-report` + `cargo llvm-cov report` not work? If you want to do something like `cargo llvm-cov run --no-run`, show-env mentioned above is the right way...
Thanks for the PR! - I would prefer to make this an option that can be opt-in with an environment variable or CLI option, rather than a feature flag. If...
> performance bottleneck I haven't measured this, but - As for `Rc` -> `Arc`, the number of clones is not very large and I think it should not cause problems....
Closing per https://github.com/taiki-e/cargo-hack/issues/128#issuecomment-2517805940. Thanks anyway for the PR!