Taiki Endo
Taiki Endo
I'll wait for https://github.com/tokio-rs/valuable/pull/12 merged and follow the decision in that PR.
Updated to use the same way as `valuable` (https://github.com/tokio-rs/valuable/pull/12).
(I should port https://github.com/tokio-rs/valuable/pull/90 to support auto-creating the PR )
> Note that this does strictly speaking break public API, since it only allows for inserting `std::usize::MAX - 1` entries instead of `std::usize::MAX`. I think this is fine, because the...
Thanks for the suggestion! > * The easiest way would be to replace the Signals with [`pipe`](https://docs.rs/signal-hook/0.3.1/signal_hook/low_level/pipe/index.html#examples). This would allow removing the feature flag and cutting down on the amount...
Thanks for the PR. Unfortunately, if the user implements the same trait on both types, this is a breaking change. (https://github.com/smol-rs/futures-lite/issues/35 is an issue to track this change.)
Sorry, I don't have time to investigate this problem at this time.
r? @smol-rs/admins
This is semi-intentional because we cannot deduce which JavaScript interface is in use from the target name alone (see also [getrandom's doc](https://docs.rs/getrandom/latest/getrandom/#webassembly-support)).
> Should I also implement TryInto on these types? It would involve unwrapping the Arc, which doesn't feel idiomatic, but it would complete the symmetry with std. Depending on how...