Taiki Endo

Results 935 comments of Taiki Endo

Supporting it as an optional dependency is a bad idea if enabling it could cause unsoundness. One of the approachs to handle such cases soundly is to use the optional...

@marius-meissner Sorry for the late response. > > as [my portable-atomic crate does](https://github.com/taiki-e/portable-atomic#optional-cfg). > > Wow, what an awesome crate! > Are there reasons against integrating this in bytes? I...

Could you update MSRV in travis.yml to 1.27.0? (that is needed to fix CI) https://github.com/carllerche/slab/blob/f1327f72fb14fb387e07a6123300eb7a9da7c4e8/.travis.yml#L8-L9

On second thought, I think the addition of safety requirements like this should actually be considered a breaking change.

If there are other breaking changes, I'm okay with releasing this and them together, but I don't want to bump the major version just for this optimization.

> that stance might delay it for a long time. I agree that this is likely to delay. However, slab is [widely used](https://crates.io/crates/slab/reverse_dependencies) so I want to avoid major version...

Is there a way to create BytesMut in const? If not, this does not seem to be available in practice.

Ah, it was previously proposed, but I closed it for compatibility with future implementation changes. https://github.com/tokio-rs/bytes/pull/472#pullrequestreview-632946191

https://github.com/rust-lang/futures-rs/pull/2400 is a more good way to do this. I'll update to use it.